SerenityOS build: Tuesday, September 13
Images 💾⌗
- serenity-i686-20220913-1d846e5.vdi.gz (VirtualBox VDI, 127.64 MiB)
- serenity-i686-20220913-1d846e5.img.gz (Raw image, 127.81 MiB)
Last commit ⭐⌗
commit 1d846e559150e1ec90486760a8e09fced24b1d67
Author: davidot <davidot@serenityos.org>
AuthorDate: Tue Sep 13 01:23:28 2022 +0200
Commit: Tim Flynn <trflynn89@pm.me>
CommitDate: Mon Sep 12 20:14:58 2022 -0400
LibWeb: Visit internal fields of Crypto in visit_edges
Not visiting the field holding SubtleCrypto in Crypto caused subtle
crashes all over the Value functions, due to accessing SubtleCrypto
after it was garbage collected (and potentially replaced by a new cell).
This meant that the crashes were only appearing in Value::to_boolean,
Value::typeof, etc. Which then held pointer to things that looked like
Shapes, Environments and other non-Object Cells.
To find the actual cause, all pointer used to construct Values were
checked and if a pointer was none of the allowed types, the backtrace
is logged.
Co-authored-by: Luke Wilde <lukew@serenityos.org>
Other builds